* [PATCH] smc: generic netlink family should be __ro_after_init
@ 2018-09-20 7:27 Johannes Berg
2018-09-20 14:50 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2018-09-20 7:27 UTC (permalink / raw)
To: linux-s390; +Cc: netdev, Ursula Braun, Johannes Berg
From: Johannes Berg <johannes.berg@intel.com>
The generic netlink family is only initialized during module init,
so it should be __ro_after_init like all other generic netlink
families.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
net/smc/smc_pnet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/smc/smc_pnet.c b/net/smc/smc_pnet.c
index 01c6ce042a1c..7cb3e4f07c10 100644
--- a/net/smc/smc_pnet.c
+++ b/net/smc/smc_pnet.c
@@ -461,7 +461,7 @@ static const struct genl_ops smc_pnet_ops[] = {
};
/* SMC_PNETID family definition */
-static struct genl_family smc_pnet_nl_family = {
+static struct genl_family smc_pnet_nl_family __ro_after_init = {
.hdrsize = 0,
.name = SMCR_GENL_FAMILY_NAME,
.version = SMCR_GENL_FAMILY_VERSION,
--
2.14.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] smc: generic netlink family should be __ro_after_init
2018-09-20 7:27 [PATCH] smc: generic netlink family should be __ro_after_init Johannes Berg
@ 2018-09-20 14:50 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-09-20 14:50 UTC (permalink / raw)
To: johannes; +Cc: linux-s390, netdev, ubraun, johannes.berg
From: Johannes Berg <johannes@sipsolutions.net>
Date: Thu, 20 Sep 2018 09:27:30 +0200
> From: Johannes Berg <johannes.berg@intel.com>
>
> The generic netlink family is only initialized during module init,
> so it should be __ro_after_init like all other generic netlink
> families.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Looks good, applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-20 20:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-20 7:27 [PATCH] smc: generic netlink family should be __ro_after_init Johannes Berg
2018-09-20 14:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).