From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] r8169: fix autoneg issue on resume with RTL8168E Date: Thu, 20 Sep 2018 19:59:45 -0700 (PDT) Message-ID: <20180920.195945.1860701614190441289.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: nic_swsd@realtek.com, netdev@vger.kernel.org, neil@nmacleod.com To: hkallweit1@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:52306 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727141AbeIUIqa (ORCPT ); Fri, 21 Sep 2018 04:46:30 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Heiner Kallweit Date: Thu, 20 Sep 2018 22:47:09 +0200 > It was reported that chip version 33 (RTL8168E) ends up with > 10MBit/Half on a 1GBit link after resuming from S3 (with different > link partners). For whatever reason the PHY on this chip doesn't > properly start a renegotiation when soft-reset. > Explicitly requesting a renegotiation fixes this. > > Signed-off-by: Heiner Kallweit > Fixes: a2965f12fde6 ("r8169: remove rtl8169_set_speed_xmii") > Reported-by: Neil MacLeod > Tested-by: Neil MacLeod Applied, thank you. Please always make "Fixes: " the first tag in a set of tags. I fixed it up for you this time. Thanks.