From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Sutter Subject: Re: [PATCH iproute2 v2 0/3] testsuite: make alltests fixes Date: Thu, 20 Sep 2018 10:02:20 +0200 Message-ID: <20180920080220.GF14666@orbyte.nwl.cc> References: <20180919233624.18494-1-petr.vorel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, Stephen Hemminger , Luca Boccassi To: Petr Vorel Return-path: Received: from orbyte.nwl.cc ([151.80.46.58]:56276 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726177AbeITNod (ORCPT ); Thu, 20 Sep 2018 09:44:33 -0400 Content-Disposition: inline In-Reply-To: <20180919233624.18494-1-petr.vorel@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Hi Petr, On Thu, Sep 20, 2018 at 01:36:21AM +0200, Petr Vorel wrote: > here are simply fixes to restore 'make alltests'. > Currently it does not run. Yeah, that testsuite definitely deserves some love. Just one nit: The one-line summary in Fixes: tags should be enclosed in quotes and parens, e.g.: | Fixes: deadbeef ("foo bar") Cheers, Phil