From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH bpf-next 2/3] bpf: emit RECORD_MMAP events for bpf prog
 load/unload
Date: Thu, 20 Sep 2018 10:44:24 +0200
Message-ID: <20180920084424.GN24124@hirez.programming.kicks-ass.net>
References: <20180919223935.999270-1-ast@kernel.org>
 <20180919223935.999270-3-ast@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "David S . Miller" <davem@davemloft.net>, daniel@iogearbox.net,
        acme@kernel.org, netdev@vger.kernel.org, kernel-team@fb.com
To: Alexei Starovoitov <ast@kernel.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from merlin.infradead.org ([205.233.59.134]:56668 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726383AbeITO05 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 20 Sep 2018 10:26:57 -0400
Content-Disposition: inline
In-Reply-To: <20180919223935.999270-3-ast@kernel.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Sep 19, 2018 at 03:39:34PM -0700, Alexei Starovoitov wrote:
>  void bpf_prog_kallsyms_del(struct bpf_prog *fp)
>  {
> +	unsigned long symbol_start, symbol_end;
> +	/* mmap_record.filename cannot be NULL and has to be u64 aligned */
> +	char buf[sizeof(u64)] = {};
> +
>  	if (!bpf_prog_kallsyms_candidate(fp))
>  		return;
>  
>  	spin_lock_bh(&bpf_lock);
>  	bpf_prog_ksym_node_del(fp->aux);
>  	spin_unlock_bh(&bpf_lock);
> +	bpf_get_prog_addr_region(fp, &symbol_start, &symbol_end);
> +	perf_event_mmap_bpf_prog(symbol_start, symbol_end - symbol_start,
> +				 buf, sizeof(buf));
>  }

So perf doesn't normally issue unmap events.. We've talked about doing
that, but so far it's never really need needed I think.

I feels a bit weird to start issuing unmap events for this.