From: Stephen Hemminger <stephen@networkplumber.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, devel@linuxdriverproject.org,
netdev@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 0/2] hv_netvsc: associate VF and PV device by serial number
Date: Thu, 20 Sep 2018 09:50:11 -0700 [thread overview]
Message-ID: <20180920095011.26406404@xeon-e3> (raw)
In-Reply-To: <20180920141820.GD838@e107981-ln.cambridge.arm.com>
On Thu, 20 Sep 2018 15:18:20 +0100
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote:
> On Fri, Sep 14, 2018 at 12:54:55PM -0700, Stephen Hemminger wrote:
> > The Hyper-V implementation of PCI controller has concept of 32 bit serial number
> > (not to be confused with PCI-E serial number). This value is sent in the protocol
> > from the host to indicate SR-IOV VF device is attached to a synthetic NIC.
> >
> > Using the serial number (instead of MAC address) to associate the two devices
> > avoids lots of potential problems when there are duplicate MAC addresses from
> > tunnels or layered devices.
> >
> > The patch set is broken into two parts, one is for the PCI controller
> > and the other is for the netvsc device. Normally, these go through different
> > trees but sending them together here for better review. The PCI changes
> > were submitted previously, but the main review comment was "why do you
> > need this?". This is why.
>
> The question was more whether we should convert this serial number into
> a PCI slot number (that has user space visibility and that is what you are
> after) to improve the current matching, I do not question why you need
> it, just for the records.
The name slot is way overloaded in this context.
There is
windows slot number which comes from Hyperv
pci address slot which pci-hyperv sets from windows slot
pci slot api value which for normal devices comes from ACPI
this patch gets it from serial number
The netvsc driver needed to be able to find a PCI device based on the serial
number. The serial number was not visible in any current PCI-hyperv controller
values. The windows slot (wslot) is not the same the serial number.
prev parent reply other threads:[~2018-09-20 22:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 19:54 [PATCH v2 0/2] hv_netvsc: associate VF and PV device by serial number Stephen Hemminger
2018-09-14 19:54 ` [PATCH v2 1/2] PCI: hv: support reporting serial number as slot information Stephen Hemminger
2018-09-14 19:54 ` [PATCH v2 2/2] hv_netvsc: pair VF based on serial number Stephen Hemminger
2018-09-20 13:43 ` Lorenzo Pieralisi
2018-09-17 14:59 ` [PATCH v2 0/2] hv_netvsc: associate VF and PV device by " David Miller
2018-09-20 14:18 ` Lorenzo Pieralisi
2018-09-20 16:50 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920095011.26406404@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).