* [PATCH] qtnfmac: remove set but not used variable 'vif'
@ 2018-09-11 12:28 YueHaibing
2018-09-11 12:58 ` Sergey Matyukevich
2018-09-20 12:12 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2018-09-11 12:28 UTC (permalink / raw)
To: Igor Mitsyanko, Avinash Patil, Sergey Matyukevich, Kalle Valo,
Sergei Maksimenko, Vasily Ulyanov, Andrey Shevchenko
Cc: YueHaibing, linux-wireless, netdev, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/quantenna/qtnfmac/cfg80211.c: In function 'qtnf_dump_survey':
drivers/net/wireless/quantenna/qtnfmac/cfg80211.c:694:19: warning:
variable 'vif' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
index 4aa332f..452d4b7 100644
--- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
+++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
@@ -691,11 +691,8 @@ static int qtnf_set_default_key(struct wiphy *wiphy, struct net_device *dev,
const struct cfg80211_chan_def *chandef = &wdev->chandef;
struct ieee80211_channel *chan;
struct qtnf_chan_stats stats;
- struct qtnf_vif *vif;
int ret;
- vif = qtnf_netdev_get_priv(dev);
-
sband = wiphy->bands[NL80211_BAND_2GHZ];
if (sband && idx >= sband->n_channels) {
idx -= sband->n_channels;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] qtnfmac: remove set but not used variable 'vif'
2018-09-11 12:28 [PATCH] qtnfmac: remove set but not used variable 'vif' YueHaibing
@ 2018-09-11 12:58 ` Sergey Matyukevich
2018-09-20 12:12 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Sergey Matyukevich @ 2018-09-11 12:58 UTC (permalink / raw)
To: YueHaibing
Cc: Igor Mitsyanko, Avinash Patil, Sergey Matyukevich, Kalle Valo,
Sergei Maksimenko, Vasily Ulyanov, Andrey Shevchenko,
linux-wireless, netdev, kernel-janitors
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/quantenna/qtnfmac/cfg80211.c: In function 'qtnf_dump_survey':
> drivers/net/wireless/quantenna/qtnfmac/cfg80211.c:694:19: warning:
> variable 'vif' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks !
Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Regards,
Sergey
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qtnfmac: remove set but not used variable 'vif'
2018-09-11 12:28 [PATCH] qtnfmac: remove set but not used variable 'vif' YueHaibing
2018-09-11 12:58 ` Sergey Matyukevich
@ 2018-09-20 12:12 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2018-09-20 12:12 UTC (permalink / raw)
To: YueHaibing
Cc: Igor Mitsyanko, Avinash Patil, Sergey Matyukevich,
Sergei Maksimenko, Vasily Ulyanov, Andrey Shevchenko, YueHaibing,
linux-wireless, netdev, kernel-janitors
YueHaibing <yuehaibing@huawei.com> wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/quantenna/qtnfmac/cfg80211.c: In function 'qtnf_dump_survey':
> drivers/net/wireless/quantenna/qtnfmac/cfg80211.c:694:19: warning:
> variable 'vif' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Patch applied to wireless-drivers-next.git, thanks.
93ed990e3a6e qtnfmac: remove set but not used variable 'vif'
--
https://patchwork.kernel.org/patch/10595609/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-20 17:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-11 12:28 [PATCH] qtnfmac: remove set but not used variable 'vif' YueHaibing
2018-09-11 12:58 ` Sergey Matyukevich
2018-09-20 12:12 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).