From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net-next, 1/3] hv_netvsc: Add support for LRO/RSC in the vSwitch Date: Thu, 20 Sep 2018 13:47:59 -0700 Message-ID: <20180920134725.3e149a0b@xeon-e3> References: <20180920170701.9574-1-haiyangz@linuxonhyperv.com> <20180920170701.9574-2-haiyangz@linuxonhyperv.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: haiyangz@microsoft.com, davem@davemloft.net, netdev@vger.kernel.org, olaf@aepfle.de, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, vkuznets@redhat.com To: Haiyang Zhang Return-path: Received: from mail-pg1-f193.google.com ([209.85.215.193]:35542 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726128AbeIUCd1 (ORCPT ); Thu, 20 Sep 2018 22:33:27 -0400 Received: by mail-pg1-f193.google.com with SMTP id 205-v6so4031111pgd.2 for ; Thu, 20 Sep 2018 13:48:07 -0700 (PDT) In-Reply-To: <20180920170701.9574-2-haiyangz@linuxonhyperv.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 20 Sep 2018 17:06:59 +0000 Haiyang Zhang wrote: > +static inline void rsc_add_data > + (struct netvsc_channel *nvchan, > + const struct ndis_pkt_8021q_info *vlan, > + const struct ndis_tcp_ip_checksum_info *csum_info, > + void *data, u32 len) > +{ Could this be changed to look more like a function and skip the inline. The compiler will end up inlining it anyway. static void rsc_add_data(struct netvsc_channel *nvchan,