From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Pieralisi Subject: Re: [PATCH v2 0/2] hv_netvsc: associate VF and PV device by serial number Date: Thu, 20 Sep 2018 15:18:20 +0100 Message-ID: <20180920141820.GD838@e107981-ln.cambridge.arm.com> References: <20180914195457.20433-1-sthemmin@microsoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, devel@linuxdriverproject.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org To: Stephen Hemminger Return-path: Received: from foss.arm.com ([217.140.101.70]:46832 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730955AbeITUCH (ORCPT ); Thu, 20 Sep 2018 16:02:07 -0400 Content-Disposition: inline In-Reply-To: <20180914195457.20433-1-sthemmin@microsoft.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Sep 14, 2018 at 12:54:55PM -0700, Stephen Hemminger wrote: > The Hyper-V implementation of PCI controller has concept of 32 bit serial number > (not to be confused with PCI-E serial number). This value is sent in the protocol > from the host to indicate SR-IOV VF device is attached to a synthetic NIC. > > Using the serial number (instead of MAC address) to associate the two devices > avoids lots of potential problems when there are duplicate MAC addresses from > tunnels or layered devices. > > The patch set is broken into two parts, one is for the PCI controller > and the other is for the netvsc device. Normally, these go through different > trees but sending them together here for better review. The PCI changes > were submitted previously, but the main review comment was "why do you > need this?". This is why. The question was more whether we should convert this serial number into a PCI slot number (that has user space visibility and that is what you are after) to improve the current matching, I do not question why you need it, just for the records. Lorenzo > v2 - slot name can be shorter. > remove locking when creating pci_slots; see comment for explaination > > Stephen Hemminger (2): > PCI: hv: support reporting serial number as slot information > hv_netvsc: pair VF based on serial number > > drivers/net/hyperv/netvsc.c | 3 ++ > drivers/net/hyperv/netvsc_drv.c | 58 ++++++++++++++++------------- > drivers/pci/controller/pci-hyperv.c | 37 ++++++++++++++++++ > 3 files changed, 73 insertions(+), 25 deletions(-) > > -- > 2.18.0 >