From: Stephen Hemminger <stephen@networkplumber.org>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"olaf@aepfle.de" <olaf@aepfle.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
vkuznets <vkuznets@redhat.com>
Subject: Re: [PATCH net-next, 1/3] hv_netvsc: Add support for LRO/RSC in the vSwitch
Date: Thu, 20 Sep 2018 17:41:23 -0700 [thread overview]
Message-ID: <20180920174123.3b86623a@xeon-e3> (raw)
In-Reply-To: <BN6PR21MB01614DCE1099980A7B1286FFCA130@BN6PR21MB0161.namprd21.prod.outlook.com>
On Thu, 20 Sep 2018 20:56:46 +0000
Haiyang Zhang <haiyangz@microsoft.com> wrote:
> > -----Original Message-----
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Thursday, September 20, 2018 4:48 PM
> > To: Haiyang Zhang <haiyangz@linuxonhyperv.com>
> > Cc: Haiyang Zhang <haiyangz@microsoft.com>; davem@davemloft.net;
> > netdev@vger.kernel.org; olaf@aepfle.de; linux-kernel@vger.kernel.org;
> > devel@linuxdriverproject.org; vkuznets <vkuznets@redhat.com>
> > Subject: Re: [PATCH net-next, 1/3] hv_netvsc: Add support for LRO/RSC in the
> > vSwitch
> >
> > On Thu, 20 Sep 2018 17:06:59 +0000
> > Haiyang Zhang <haiyangz@linuxonhyperv.com> wrote:
> >
> > > +static inline void rsc_add_data
> > > + (struct netvsc_channel *nvchan,
> > > + const struct ndis_pkt_8021q_info *vlan,
> > > + const struct ndis_tcp_ip_checksum_info *csum_info,
> > > + void *data, u32 len)
> > > +{
> >
> > Could this be changed to look more like a function and skip the inline.
> > The compiler will end up inlining it anyway.
> >
> > static void rsc_add_data(struct netvsc_channel *nvchan,
>
> How about this?
> static inline
> void rsc_add_data(struct netvsc_channel *nvchan,
>
Sure that matches other code in that file
next prev parent reply other threads:[~2018-09-21 6:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 17:06 [PATCH net-next,0/3] hv_netvsc: Support LRO/RSC in the vSwitch Haiyang Zhang
2018-09-20 17:06 ` [PATCH net-next,1/3] hv_netvsc: Add support for " Haiyang Zhang
2018-09-20 20:47 ` [PATCH net-next, 1/3] " Stephen Hemminger
2018-09-20 20:56 ` Haiyang Zhang
2018-09-21 0:41 ` Stephen Hemminger [this message]
2018-09-20 17:07 ` [PATCH net-next,2/3] hv_netvsc: Add handler for LRO setting change Haiyang Zhang
2018-09-20 17:07 ` [PATCH net-next,3/3] hv_netvsc: Update document for LRO/RSC support Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920174123.3b86623a@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).