From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net-next, 1/3] hv_netvsc: Add support for LRO/RSC in the vSwitch Date: Thu, 20 Sep 2018 17:41:23 -0700 Message-ID: <20180920174123.3b86623a@xeon-e3> References: <20180920170701.9574-1-haiyangz@linuxonhyperv.com> <20180920170701.9574-2-haiyangz@linuxonhyperv.com> <20180920134725.3e149a0b@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "davem@davemloft.net" , "netdev@vger.kernel.org" , "olaf@aepfle.de" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , vkuznets To: Haiyang Zhang Return-path: Received: from mail-pf1-f195.google.com ([209.85.210.195]:40563 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725794AbeIUG1m (ORCPT ); Fri, 21 Sep 2018 02:27:42 -0400 Received: by mail-pf1-f195.google.com with SMTP id s13-v6so5145387pfi.7 for ; Thu, 20 Sep 2018 17:41:31 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 20 Sep 2018 20:56:46 +0000 Haiyang Zhang wrote: > > -----Original Message----- > > From: Stephen Hemminger > > Sent: Thursday, September 20, 2018 4:48 PM > > To: Haiyang Zhang > > Cc: Haiyang Zhang ; davem@davemloft.net; > > netdev@vger.kernel.org; olaf@aepfle.de; linux-kernel@vger.kernel.org; > > devel@linuxdriverproject.org; vkuznets > > Subject: Re: [PATCH net-next, 1/3] hv_netvsc: Add support for LRO/RSC in the > > vSwitch > > > > On Thu, 20 Sep 2018 17:06:59 +0000 > > Haiyang Zhang wrote: > > > > > +static inline void rsc_add_data > > > + (struct netvsc_channel *nvchan, > > > + const struct ndis_pkt_8021q_info *vlan, > > > + const struct ndis_tcp_ip_checksum_info *csum_info, > > > + void *data, u32 len) > > > +{ > > > > Could this be changed to look more like a function and skip the inline. > > The compiler will end up inlining it anyway. > > > > static void rsc_add_data(struct netvsc_channel *nvchan, > > How about this? > static inline > void rsc_add_data(struct netvsc_channel *nvchan, > Sure that matches other code in that file