From: Florian Westphal <fw@strlen.de>
To: dsahern@kernel.org
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
pablo@netfilter.org, fw@strlen.de,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net-next 0/3] net: wean netfilter from fib_nh
Date: Thu, 20 Sep 2018 22:53:30 +0200 [thread overview]
Message-ID: <20180920205330.a6alwd6pz7xul3a7@breakpoint.cc> (raw)
In-Reply-To: <20180920205049.15143-1-dsahern@kernel.org>
dsahern@kernel.org <dsahern@kernel.org> wrote:
> From: David Ahern <dsahern@gmail.com>
>
> Two netfilter modules reference fib_nh. In both cases the code is
> only checking if a nexthop in a fib_info uses a specific device.
> Both instances essentially duplicate code from __fib_validate_source,
> so move that code into a helper and flip the netfilter modules to
> use it.
Lokks good to me, thanks David.
next prev parent reply other threads:[~2018-09-21 2:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 20:50 [PATCH net-next 0/3] net: wean netfilter from fib_nh dsahern
2018-09-20 20:50 ` [PATCH net-next 1/3] net/ipv4: Move device validation to helper dsahern
2018-09-20 20:50 ` [PATCH net-next 2/3] netfilter: rpfilter: Convert rpfilter_lookup_reverse to new dev helper dsahern
2018-09-20 20:50 ` [PATCH net-next 3/3] netfilter: nft_fib: Convert nft_fib4_eval " dsahern
2018-09-20 20:53 ` Florian Westphal [this message]
2018-09-21 3:02 ` [PATCH net-next 0/3] net: wean netfilter from fib_nh David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920205330.a6alwd6pz7xul3a7@breakpoint.cc \
--to=fw@strlen.de \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).