From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH nf-next] netfilter: ctnetlink: must check mark attributes vs NULL Date: Fri, 21 Sep 2018 10:14:58 +0200 Message-ID: <20180921081458.l42yaho6r6sfd76f@salvia> References: <000000000000f4bf02057653dc0a@google.com> <20180920215306.10018-1-fw@strlen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org, syzbot+e45eda8eda6e93a03959@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com, netdev@vger.kernel.org, kristian.evensen@gmail.com To: Florian Westphal Return-path: Received: from mail.us.es ([193.147.175.20]:60488 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726479AbeIUOCr (ORCPT ); Fri, 21 Sep 2018 10:02:47 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 2F41112C002 for ; Fri, 21 Sep 2018 10:15:01 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 1CF02DA8F5 for ; Fri, 21 Sep 2018 10:15:01 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20180920215306.10018-1-fw@strlen.de> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Sep 20, 2018 at 11:53:06PM +0200, Florian Westphal wrote: > else we will oops (null deref) when the attributes aren't present. > > Also add back the EOPNOTSUPP in case MARK filtering is requested but > kernel doesn't support it. Applied, thanks Florian.