From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?H=C3=A5kon=20Bugge?= Subject: [PATCH 0/2] net: if_arp: use define instead of hard-coded value Date: Fri, 21 Sep 2018 12:39:28 +0200 Message-ID: <20180921103930.1420679-1-Haakon.Bugge@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: "David S . Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Struct arpreq contains the name of the device. All other places in the kernel, the define IFNAMSIZ is used to designate its size. But in if_arp.h, a literal constant is used. As it could be good reasons to use constants instead of the defines in include files under uapi, it seems to be OK to use the define here, without opening a can of worms in user-land. This because if_arp.h includes netdevice.h, which also uses IFNAMSIZ. For the distros I have checked, this also holds true for the use-land side. The series also fixes some incorrect indents. Håkon Bugge (2): net: if_arp: Fix incorrect indents net: if_arp: use define instead of hard-coded value include/uapi/linux/if_arp.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) -- 2.14.3