From: Arjun Vynipadath <arjun@chelsio.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, dt@chelsio.com,
nirranjan@chelsio.com, indranil@chelsio.com,
Casey Leedom <leedom@chelsio.com>,
Ganesh Goudar <ganeshgr@chelsio.com>
Subject: Re: [PATCH net-next] cxgb4vf: Add ethtool private flags for changing force_link_up
Date: Fri, 21 Sep 2018 16:16:31 +0530 [thread overview]
Message-ID: <20180921104629.GA20315@chelsio.com> (raw)
In-Reply-To: <20180918113914.58811ecf@cakuba.netronome.com>
On Tuesday, September 09/18/18, 2018 at 11:39:14 -0700, Jakub Kicinski wrote:
> On Tue, 18 Sep 2018 18:37:23 +0530, Arjun Vynipadath wrote:
> > Forcing link up of virtual interfaces even when physical link is down
> > causes packet drops and ping failures during bonding failover. Hence
> > adding a ethtool private flag to toggle force_link_up whenever required.
> >
> > Signed-off-by: Arjun Vynipadath <arjun@chelsio.com>
> > Signed-off-by: Casey Leedom <leedom@chelsio.com>
> > Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>
>
> Could you describe how this mechanism relates to the existing
> ndo_set_vf_link_state, which you seem to not make use of:
>
> $ git grep ndo_set_vf_link_state -- drivers/net/ethernet/chelsio/
> $
>
> I understand you're configuring the setting from the VF side, but the
> question, as always, is: why ;)
Hi Jakub,
ndo_set_vf_link_state can't be presently used in our case.
We dont have firmware support to communicate the link flags set through
ndo_set_vf_link_state from pf (cxgb4) driver to vf (cxgb4vf) driver.
Thanks,
Arjun.
next prev parent reply other threads:[~2018-09-21 16:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 13:07 [PATCH net-next] cxgb4vf: Add ethtool private flags for changing force_link_up Arjun Vynipadath
2018-09-18 18:39 ` Jakub Kicinski
2018-09-21 10:46 ` Arjun Vynipadath [this message]
2018-09-21 15:46 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921104629.GA20315@chelsio.com \
--to=arjun@chelsio.com \
--cc=davem@davemloft.net \
--cc=dt@chelsio.com \
--cc=ganeshgr@chelsio.com \
--cc=indranil@chelsio.com \
--cc=jakub.kicinski@netronome.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).