From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arjun Vynipadath Subject: Re: [PATCH net-next] cxgb4vf: Add ethtool private flags for changing force_link_up Date: Fri, 21 Sep 2018 16:16:31 +0530 Message-ID: <20180921104629.GA20315@chelsio.com> References: <1537276043-20666-1-git-send-email-arjun@chelsio.com> <20180918113914.58811ecf@cakuba.netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, dt@chelsio.com, nirranjan@chelsio.com, indranil@chelsio.com, Casey Leedom , Ganesh Goudar To: Jakub Kicinski Return-path: Received: from stargate.chelsio.com ([12.32.117.8]:31049 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389010AbeIUQfE (ORCPT ); Fri, 21 Sep 2018 12:35:04 -0400 Content-Disposition: inline In-Reply-To: <20180918113914.58811ecf@cakuba.netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tuesday, September 09/18/18, 2018 at 11:39:14 -0700, Jakub Kicinski wrote: > On Tue, 18 Sep 2018 18:37:23 +0530, Arjun Vynipadath wrote: > > Forcing link up of virtual interfaces even when physical link is down > > causes packet drops and ping failures during bonding failover. Hence > > adding a ethtool private flag to toggle force_link_up whenever required. > > > > Signed-off-by: Arjun Vynipadath > > Signed-off-by: Casey Leedom > > Signed-off-by: Ganesh Goudar > > Could you describe how this mechanism relates to the existing > ndo_set_vf_link_state, which you seem to not make use of: > > $ git grep ndo_set_vf_link_state -- drivers/net/ethernet/chelsio/ > $ > > I understand you're configuring the setting from the VF side, but the > question, as always, is: why ;) Hi Jakub, ndo_set_vf_link_state can't be presently used in our case. We dont have firmware support to communicate the link flags set through ndo_set_vf_link_state from pf (cxgb4) driver to vf (cxgb4vf) driver. Thanks, Arjun.