From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: [PATCH net-next 1/2] net: dsa: b53: Fix B53_SERDES_DIGITAL_CONTROL offset Date: Fri, 21 Sep 2018 16:43:58 -0700 Message-ID: <20180921234359.13069-3-f.fainelli@gmail.com> References: <20180921234359.13069-1-f.fainelli@gmail.com> Cc: andrew@lunn.ch, rmk+kernel@armlinux.org.uk, davem@davemloft.net, Florian Fainelli To: netdev@vger.kernel.org Return-path: Received: from mail-qt1-f193.google.com ([209.85.160.193]:45297 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726170AbeIVFhO (ORCPT ); Sat, 22 Sep 2018 01:37:14 -0400 Received: by mail-qt1-f193.google.com with SMTP id l2-v6so3444687qtr.12 for ; Fri, 21 Sep 2018 16:46:04 -0700 (PDT) In-Reply-To: <20180921234359.13069-1-f.fainelli@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Maths went wrong, to get 0x20, we need to do 0x1e + (x) * 2, not 0x18, fix that offset so we access the correct registers. This would make us not access the correct SerDes Digital control words, status would be fine and so we would not be correctly flipping between Fiber and SGMII modes resulting in incorrect status words being pulled into the SerDes digital status register. Fixes: 0e01491de646 ("net: dsa: b53: Add SerDes support") Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_serdes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/b53/b53_serdes.h b/drivers/net/dsa/b53/b53_serdes.h index eed7c9357091..3bb4f91aec9e 100644 --- a/drivers/net/dsa/b53/b53_serdes.h +++ b/drivers/net/dsa/b53/b53_serdes.h @@ -20,7 +20,7 @@ #define SERDES_ID0_REV_LETTER_SHIFT 14 #define B53_SERDES_MII_REG(x) (0x20 + (x) * 2) -#define B53_SERDES_DIGITAL_CONTROL(x) (0x18 + (x) * 2) +#define B53_SERDES_DIGITAL_CONTROL(x) (0x1e + (x) * 2) #define B53_SERDES_DIGITAL_STATUS 0x28 /* SERDES_DIGITAL_CONTROL1 */ -- 2.17.1