* [PATCH net] net: sched: act_ipt: check for underflow in __tcf_ipt_init()
@ 2018-09-22 13:46 Dan Carpenter
2018-10-02 5:34 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2018-09-22 13:46 UTC (permalink / raw)
To: Jamal Hadi Salim, Patrick McHardy
Cc: Cong Wang, Jiri Pirko, David S. Miller, netdev, kernel-janitors
If "td->u.target_size" is larger than sizeof(struct xt_entry_target) we
return -EINVAL. But we don't check whether it's smaller than
sizeof(struct xt_entry_target) and that could lead to an out of bounds
read.
Fixes: 7ba699c604ab ("[NET_SCHED]: Convert actions from rtnetlink to new netlink API")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I haven't tested this. Please review carefully.
diff --git a/net/sched/act_ipt.c b/net/sched/act_ipt.c
index 1efbfb10b1fc..8af6c11d2482 100644
--- a/net/sched/act_ipt.c
+++ b/net/sched/act_ipt.c
@@ -135,7 +135,7 @@ static int __tcf_ipt_init(struct net *net, unsigned int id, struct nlattr *nla,
}
td = (struct xt_entry_target *)nla_data(tb[TCA_IPT_TARG]);
- if (nla_len(tb[TCA_IPT_TARG]) < td->u.target_size) {
+ if (nla_len(tb[TCA_IPT_TARG]) != td->u.target_size) {
if (exists)
tcf_idr_release(*a, bind);
else
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-02 12:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-22 13:46 [PATCH net] net: sched: act_ipt: check for underflow in __tcf_ipt_init() Dan Carpenter
2018-10-02 5:34 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).