From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org,
Antoine Tenart <antoine.tenart@bootlin.com>,
Gregory CLEMENT <gregory.clement@bootlin.com>
Subject: Re: [PATCH] net: phy: phylink: fix SFP interface autodetection
Date: Sat, 22 Sep 2018 20:18:00 +0100 [thread overview]
Message-ID: <20180922191800.GN30658@n2100.armlinux.org.uk> (raw)
In-Reply-To: <be339ca81893a87e382a41da84d17850a4cfe940.1537643384.git.baruch@tkos.co.il>
On Sat, Sep 22, 2018 at 10:09:44PM +0300, Baruch Siach wrote:
> When connecting a PHY to phylink use the detected interface. Otherwise,
> the link fails to come up when the configured 'phy-mode' differs from
> the SFP detected mode.
>
> This fixes 1GB SFP module link up on eth3 of the Macchiatobin board that
> is configured in the DT to "2500base-x" phy-mode.
What I actually meant is that a PHY attached from a SFP interface
should use link_config.interface. A PHY attached as not part of
a SFP interface should continue using the DT-parsed link_interface.
What I envisaged seeing is phylink_connect_phy() being renamed to
__phylink_connect_phy(), and taking the phy interface,
phylink_sfp_connect_phy() calling __phylink_connect_phy() with
link_config.interface, and a replacement phylink_connect_phy() which
called __phylink_connect_phy() with link_interface.
Sorry I wasn't explicit enough last time around.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up
According to speedtest.net: 13Mbps down 490kbps up
next prev parent reply other threads:[~2018-09-23 1:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-22 19:09 [PATCH] net: phy: phylink: fix SFP interface autodetection Baruch Siach
2018-09-22 19:18 ` Russell King - ARM Linux [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-09-17 14:19 Baruch Siach
2018-09-17 15:12 ` Russell King - ARM Linux
2018-09-17 15:39 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180922191800.GN30658@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=baruch@tkos.co.il \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).