From: Ido Schimmel <idosch@idosch.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Ido Schimmel <idosch@mellanox.com>,
netdev@vger.kernel.org, davem@davemloft.net, jiri@mellanox.com,
petrm@mellanox.com, mlxsw@mellanox.com
Subject: Re: [PATCH net-next] mlxsw: Make MLXSW_SP1_FWREV_MINOR a hard requirement
Date: Mon, 24 Sep 2018 00:51:00 +0300 [thread overview]
Message-ID: <20180923215100.GA24149@splinter> (raw)
In-Reply-To: <20180923205809.GA30338@lunn.ch>
On Sun, Sep 23, 2018 at 10:58:09PM +0200, Andrew Lunn wrote:
> > Therefore tweak the check to accept any FW version that is:
> >
> > - on the same branch as the preferred version, and
> > - the same as or newer than the preferred version.
>
> Hi Ido
>
> Do you print this information out? If the check fails, it would be
> useful to know what the minimal version is.
Hi Andrew,
Yes, we do print it. It is the version the driver will try to load
during initialization in case current version is incompatible:
dev_info(mlxsw_sp->bus_info->dev, "Flashing firmware using file %s\n",
fw_filename);
next prev parent reply other threads:[~2018-09-24 3:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-23 14:48 [PATCH net-next] mlxsw: Make MLXSW_SP1_FWREV_MINOR a hard requirement Ido Schimmel
2018-09-23 20:58 ` Andrew Lunn
2018-09-23 21:51 ` Ido Schimmel [this message]
2018-09-23 22:04 ` Andrew Lunn
2018-09-23 22:28 ` Ido Schimmel
2018-09-24 11:14 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180923215100.GA24149@splinter \
--to=idosch@idosch.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).