From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ido Schimmel <idosch@idosch.org>
Subject: Re: [PATCH net-next] mlxsw: Make MLXSW_SP1_FWREV_MINOR a hard
 requirement
Date: Mon, 24 Sep 2018 00:51:00 +0300
Message-ID: <20180923215100.GA24149@splinter>
References: <20180923144855.26444-1-idosch@mellanox.com>
 <20180923205809.GA30338@lunn.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Ido Schimmel <idosch@mellanox.com>, netdev@vger.kernel.org,
        davem@davemloft.net, jiri@mellanox.com, petrm@mellanox.com,
        mlxsw@mellanox.com
To: Andrew Lunn <andrew@lunn.ch>
Return-path: <netdev-owner@vger.kernel.org>
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:52671 "EHLO
        out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1726520AbeIXDuI (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 23 Sep 2018 23:50:08 -0400
Content-Disposition: inline
In-Reply-To: <20180923205809.GA30338@lunn.ch>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Sun, Sep 23, 2018 at 10:58:09PM +0200, Andrew Lunn wrote:
> > Therefore tweak the check to accept any FW version that is:
> > 
> > - on the same branch as the preferred version, and
> > - the same as or newer than the preferred version.
> 
> Hi Ido
> 
> Do you print this information out? If the check fails, it would be
> useful to know what the minimal version is.

Hi Andrew,

Yes, we do print it. It is the version the driver will try to load
during initialization in case current version is incompatible:

dev_info(mlxsw_sp->bus_info->dev, "Flashing firmware using file %s\n",
	 fw_filename);