From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: Ping: [PATCH 0/3] xen-netback: hash mapping hanling adjustments Date: Mon, 24 Sep 2018 09:49:20 -0700 (PDT) Message-ID: <20180924.094920.655625438524720848.davem@davemloft.net> References: <5B9778D702000078001E7069@prv1-mh.provo.novell.com> <20180911101623.3tuzvlyr7musocrg@zion.uk.xensource.com> <5BA895B602000078001EB059@prv1-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: paul.durrant@citrix.com, wei.liu2@citrix.com, xen-devel@lists.xenproject.org, netdev@vger.kernel.org To: JBeulich@suse.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:48968 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728916AbeIXWwX (ORCPT ); Mon, 24 Sep 2018 18:52:23 -0400 In-Reply-To: <5BA895B602000078001EB059@prv1-mh.provo.novell.com> Sender: netdev-owner@vger.kernel.org List-ID: From: "Jan Beulich" Date: Mon, 24 Sep 2018 01:43:50 -0600 >>>> On 11.09.18 at 12:16, wrote: >> On Tue, Sep 11, 2018 at 02:12:07AM -0600, Jan Beulich wrote: >>> >>> On 28.08.18 at 16:54, wrote: >>> > First and foremost the fix for XSA-270. On top of that further changes >>> > which looked desirable to me while investigating that XSA. >>> > >>> > 1: fix input validation in xenvif_set_hash_mapping() >>> > 2: validate queue numbers in xenvif_set_hash_mapping() >>> > 3: handle page straddling in xenvif_set_hash_mapping() >>> > >>> > Signed-off-by: Jan Beulich >>> >>> What is the way forward here? I've got R-b-s from Paul for all three >>> patches, and a minor change request on patch 2 from Wei. I'm not >>> really certain what to do in this case (hints appreciated), but could >>> at least the security fix (patch 1) be applied immediately? >> >> If you happen to resend, please make the adjustment; otherwise I'm fine >> with the patches as they are. I don't want to block useful things on >> cosmetic issues. > > Dave? I notice none of the patches is in 4.19-rc5, not even the security > fix, the advisory for which had gone public over a month ago. If it's not in my patchwork queue, you have to resend the series and make it clear that it should be applied to the networking tree by putting "[PATCH net N/M]" in the Subject lines. Thank you.