From: David Miller <davem@davemloft.net>
To: stefan.wahren@i2se.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
michael.heimpold@i2se.com
Subject: Re: [PATCH] net: qca_spi: Introduce write register verification
Date: Mon, 24 Sep 2018 12:26:29 -0700 (PDT) [thread overview]
Message-ID: <20180924.122629.891745867586399526.davem@davemloft.net> (raw)
In-Reply-To: <1537788010-6766-1-git-send-email-stefan.wahren@i2se.com>
From: Stefan Wahren <stefan.wahren@i2se.com>
Date: Mon, 24 Sep 2018 13:20:10 +0200
> The SPI protocol for the QCA7000 doesn't have any fault detection.
> In order to increase the drivers reliability in noisy environments,
> we could implement a write verification inspired by the enc28j60.
> This should avoid situations were the driver wrongly assumes the
> receive interrupt is enabled and miss all incoming packets.
>
> This function is disabled per default and can be controlled via module
> parameter wr_verify.
>
> Signed-off-by: Michael Heimpold <michael.heimpold@i2se.com>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Applied.
prev parent reply other threads:[~2018-09-24 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 11:20 [PATCH] net: qca_spi: Introduce write register verification Stefan Wahren
2018-09-24 19:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924.122629.891745867586399526.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.heimpold@i2se.com \
--cc=netdev@vger.kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox