From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: mvneta: fix the remaining Rx descriptor unmapping issues Date: Mon, 24 Sep 2018 12:29:10 -0700 (PDT) Message-ID: <20180924.122910.450816619429773171.davem@davemloft.net> References: <20180924145613.27307-1-antoine.tenart@bootlin.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: yelena@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, maxime.chevallier@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com To: antoine.tenart@bootlin.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:51190 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726269AbeIYBcx (ORCPT ); Mon, 24 Sep 2018 21:32:53 -0400 In-Reply-To: <20180924145613.27307-1-antoine.tenart@bootlin.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Antoine Tenart Date: Mon, 24 Sep 2018 16:56:13 +0200 > With CONFIG_DMA_API_DEBUG enabled we get DMA unmapping warning in > various places of the mvneta driver, for example when putting down an > interface while traffic is passing through. > > The issue is when using s/w buffer management, the Rx buffers are mapped > using dma_map_page but unmapped with dma_unmap_single. This patch fixes > this by using the right unmapping function. > > Fixes: 562e2f467e71 ("net: mvneta: Improve the buffer allocation method for SWBM") > Signed-off-by: Antoine Tenart Applied.