From: Steffen Klassert <steffen.klassert@secunet.com>
To: Sean Tranchetti <stranche@codeaurora.org>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH net] xfrm: validate template mode
Date: Mon, 24 Sep 2018 10:03:51 +0200 [thread overview]
Message-ID: <20180924080351.GA3823@gauss3.secunet.de> (raw)
In-Reply-To: <1537386896-5425-1-git-send-email-stranche@codeaurora.org>
On Wed, Sep 19, 2018 at 01:54:56PM -0600, Sean Tranchetti wrote:
> XFRM mode parameters passed as part of the user templates
> in the IP_XFRM_POLICY are never properly validated. Passing
> values other than valid XFRM modes can cause stack-out-of-bounds
> reads to occur later in the XFRM processing:
>
> [ 140.535608] ================================================================
> [ 140.543058] BUG: KASAN: stack-out-of-bounds in xfrm_state_find+0x17e4/0x1cc4
> [ 140.550306] Read of size 4 at addr ffffffc0238a7a58 by task repro/5148
> [ 140.557369]
> [ 140.558927] Call trace:
> [ 140.558936] dump_backtrace+0x0/0x388
> [ 140.558940] show_stack+0x24/0x30
> [ 140.558946] __dump_stack+0x24/0x2c
> [ 140.558949] dump_stack+0x8c/0xd0
> [ 140.558956] print_address_description+0x74/0x234
> [ 140.558960] kasan_report+0x240/0x264
> [ 140.558963] __asan_report_load4_noabort+0x2c/0x38
> [ 140.558967] xfrm_state_find+0x17e4/0x1cc4
> [ 140.558971] xfrm_resolve_and_create_bundle+0x40c/0x1fb8
> [ 140.558975] xfrm_lookup+0x238/0x1444
> [ 140.558977] xfrm_lookup_route+0x48/0x11c
> [ 140.558984] ip_route_output_flow+0x88/0xc4
> [ 140.558991] raw_sendmsg+0xa74/0x266c
> [ 140.558996] inet_sendmsg+0x258/0x3b0
> [ 140.559002] sock_sendmsg+0xbc/0xec
> [ 140.559005] SyS_sendto+0x3a8/0x5a8
> [ 140.559008] el0_svc_naked+0x34/0x38
> [ 140.559009]
> [ 140.592245] page dumped because: kasan: bad access detected
> [ 140.597981] page_owner info is not active (free page?)
> [ 140.603267]
> [ 140.653503] ================================================================
>
> Signed-off-by: Sean Tranchetti <stranche@codeaurora.org>
Applied to the ipsec tree, thanks a lot!
prev parent reply other threads:[~2018-09-24 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 19:54 [PATCH net] xfrm: validate template mode Sean Tranchetti
2018-09-24 8:03 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924080351.GA3823@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=netdev@vger.kernel.org \
--cc=stranche@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).