From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [PATCH v2 net-next 9/9] devlink: Add
 Documentation/networking/devlink-params-bnxt.txt
Date: Mon, 24 Sep 2018 09:24:06 -0700
Message-ID: <20180924092406.539fc54f@cakuba.netronome.com>
References: <1537766181-18994-1-git-send-email-vasundhara-v.volam@broadcom.com>
        <1537766181-18994-10-git-send-email-vasundhara-v.volam@broadcom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: davem@davemloft.net, michael.chan@broadcom.com,
        netdev@vger.kernel.org
To: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-qt1-f193.google.com ([209.85.160.193]:38115 "EHLO
        mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729013AbeIXW1G (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 24 Sep 2018 18:27:06 -0400
Received: by mail-qt1-f193.google.com with SMTP id z13-v6so10071075qts.5
        for <netdev@vger.kernel.org>; Mon, 24 Sep 2018 09:24:10 -0700 (PDT)
In-Reply-To: <1537766181-18994-10-git-send-email-vasundhara-v.volam@broadcom.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, 24 Sep 2018 10:46:21 +0530, Vasundhara Volam wrote:
> This patch adds a new file to add information about configuration
> parameters that are supported by bnxt_en driver via devlink.
> 
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> Cc: Jiri Pirko <jiri@mellanox.com>
> Cc: Michael Chan <michael.chan@broadcom.com>
> 
> Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
> ---
>  Documentation/networking/devlink-params-bnxt.txt | 35 ++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 Documentation/networking/devlink-params-bnxt.txt
> 
> diff --git a/Documentation/networking/devlink-params-bnxt.txt b/Documentation/networking/devlink-params-bnxt.txt
> new file mode 100644
> index 0000000..ca7c457
> --- /dev/null
> +++ b/Documentation/networking/devlink-params-bnxt.txt
> @@ -0,0 +1,35 @@
> +enable_sriov		[DEVICE, GENERIC]
> +			Enable Single Root I/O Virtualisation (SRIOV) in
> +			the device.
> +			Type: Boolean
> +			Configuration mode: Permanent
> +
> +ignore_ari		[DEVICE, GENERIC]
> +			Ignore Alternative Routing-ID Interpretation (ARI)
> +			capability. If enabled, adapter will ignore ARI
> +			capability even when platforms has the support
> +			enabled and creates same number of partitions when
> +			platform does not support ARI.
> +			Type: Boolean
> +			Configuration mode: Permanent
> +
> +msix_vec_per_pf_max	[DEVICE, GENERIC]
> +			Provides the maximum number of MSIX interrupts that
> +			a device can create. Value is same across all
> +			physical functions (PFs) in the device.
> +			Type: u32
> +			Configuration mode: Permanent
> +
> +msix_vec_per_pf_min	[DEVICE, GENERIC]
> +			Provides the minimum number of MSIX interrupts required
> +			or the device initialization. Value is same across all
> +			physical functions (PFs) in the device.
> +			Type: u32
> +			Configuration mode: Permanent

Why duplicate the description of the generic parameters?

> +gre_ver_check		[DEVICE, DRIVER-SPECIFIC]
> +			Generic Routing Encapsulation (GRE) version check will
> +			be enabled in the device. If disabled, device skips
> +			version checking for incoming packets.
> +			Type: Boolean
> +			Configuration mode: Permanent