From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH v2 net-next 0/9] bnxt_en: devlink param updates Date: Mon, 24 Sep 2018 09:39:08 -0700 Message-ID: <20180924093908.157f3ea2@cakuba.netronome.com> References: <1537766181-18994-1-git-send-email-vasundhara-v.volam@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, michael.chan@broadcom.com, netdev@vger.kernel.org To: Vasundhara Volam Return-path: Received: from mail-qt1-f174.google.com ([209.85.160.174]:37301 "EHLO mail-qt1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728846AbeIXWob (ORCPT ); Mon, 24 Sep 2018 18:44:31 -0400 Received: by mail-qt1-f174.google.com with SMTP id n6-v6so10131686qtl.4 for ; Mon, 24 Sep 2018 09:41:30 -0700 (PDT) In-Reply-To: <1537766181-18994-1-git-send-email-vasundhara-v.volam@broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 24 Sep 2018 10:46:12 +0530, Vasundhara Volam wrote: > This patchset adds support for 3 generic and 1 driver-specific devlink > parameters. Add documentation for these configuration parameters. > > Also, this patchset adds support to return proper error code if > HWRM_NVM_GET/SET_VARIABLE commands return error code > HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED. > > v1->v2: > -Remove hw_tc_offload parameter. > -Update all patches with Cc of MAINTAINERS. > -Add more description in commit message for device specific parameter. > -Add a new Documentation/networking/devlink-params.txt with some > generic devlink parameters information. > -Add a new Documentation/networking/devlink-params-bnxt_en.txt with devlink > parameters information that are supported by bnxt_en driver. > > Vasundhara Volam (9): > devlink: Add generic parameter ignore_ari > devlink: Add generic parameter msix_vec_per_pf_max > devlink: Add generic parameter msix_vec_per_pf_min Nobody agreed with me that we need structure the PCIe bits better so I'll let go... > bnxt_en: Use ignore_ari devlink parameter > bnxt_en: return proper error when FW returns > HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED > bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink > params. > bnxt_en: Add a driver specific gre_ver_check devlink parameter. This looks like configuring forwarding rules with devlink, but again, I won't object if I'm the only one who finds this inappropriate. You should CC people who gave you feedback on the previous version. > devlink: Add Documentation/networking/devlink-params.txt > devlink: Add Documentation/networking/devlink-params-bnxt.txt