From: David Miller <davem@davemloft.net>
To: michal.simek@xilinx.com
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
edgar.iglesias@xilinx.com, netdev@vger.kernel.org,
nicolas.ferre@microchip.com
Subject: Re: [PATCH v2] net: macb: Clean 64b dma addresses if they are not detected
Date: Tue, 25 Sep 2018 10:37:05 -0700 (PDT) [thread overview]
Message-ID: <20180925.103705.90948916724711521.davem@davemloft.net> (raw)
In-Reply-To: <68051905ba59d7cfd74c63ef5bf0830dc2b9f6fe.1537857166.git.michal.simek@xilinx.com>
From: Michal Simek <michal.simek@xilinx.com>
Date: Tue, 25 Sep 2018 08:32:50 +0200
> Clear ADDR64 dma bit in DMACFG register in case that HW_DMA_CAP_64B is
> not detected on 64bit system.
> The issue was observed when bootloader(u-boot) does not check macb
> feature at DCFG6 register (DAW64_OFFSET) and enabling 64bit dma support
> by default. Then macb driver is reading DMACFG register back and only
> adding 64bit dma configuration but not cleaning it out.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> Changes in v2:
> - Clean reg at the first place - Edgar
> - Update commit message
Applied, thank you.
prev parent reply other threads:[~2018-09-25 17:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 6:32 [PATCH v2] net: macb: Clean 64b dma addresses if they are not detected Michal Simek
2018-09-25 7:00 ` Nicolas Ferre
2018-09-25 17:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925.103705.90948916724711521.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edgar.iglesias@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).