* [PATCH v2] net: macb: Clean 64b dma addresses if they are not detected
@ 2018-09-25 6:32 Michal Simek
2018-09-25 7:00 ` Nicolas Ferre
2018-09-25 17:37 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Michal Simek @ 2018-09-25 6:32 UTC (permalink / raw)
To: linux-kernel, monstr, Edgar E. Iglesias
Cc: David S. Miller, netdev, Nicolas Ferre
Clear ADDR64 dma bit in DMACFG register in case that HW_DMA_CAP_64B is
not detected on 64bit system.
The issue was observed when bootloader(u-boot) does not check macb
feature at DCFG6 register (DAW64_OFFSET) and enabling 64bit dma support
by default. Then macb driver is reading DMACFG register back and only
adding 64bit dma configuration but not cleaning it out.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
Changes in v2:
- Clean reg at the first place - Edgar
- Update commit message
drivers/net/ethernet/cadence/macb_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 16e4ef7d7185..ed8a5c53467e 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -2160,6 +2160,7 @@ static void macb_configure_dma(struct macb *bp)
else
dmacfg &= ~GEM_BIT(TXCOEN);
+ dmacfg &= ~GEM_BIT(ADDR64);
#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
if (bp->hw_dma_cap & HW_DMA_CAP_64B)
dmacfg |= GEM_BIT(ADDR64);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net: macb: Clean 64b dma addresses if they are not detected
2018-09-25 6:32 [PATCH v2] net: macb: Clean 64b dma addresses if they are not detected Michal Simek
@ 2018-09-25 7:00 ` Nicolas Ferre
2018-09-25 17:37 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2018-09-25 7:00 UTC (permalink / raw)
To: Michal Simek, linux-kernel, monstr, Edgar E. Iglesias
Cc: David S. Miller, netdev, Claudiu Beznea - M18063
On 25/09/2018 at 08:32, Michal Simek wrote:
> Clear ADDR64 dma bit in DMACFG register in case that HW_DMA_CAP_64B is
> not detected on 64bit system.
> The issue was observed when bootloader(u-boot) does not check macb
> feature at DCFG6 register (DAW64_OFFSET) and enabling 64bit dma support
> by default. Then macb driver is reading DMACFG register back and only
> adding 64bit dma configuration but not cleaning it out.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks Michal. Best regards,
Nicolas
> ---
>
> Changes in v2:
> - Clean reg at the first place - Edgar
> - Update commit message
>
> drivers/net/ethernet/cadence/macb_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 16e4ef7d7185..ed8a5c53467e 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -2160,6 +2160,7 @@ static void macb_configure_dma(struct macb *bp)
> else
> dmacfg &= ~GEM_BIT(TXCOEN);
>
> + dmacfg &= ~GEM_BIT(ADDR64);
> #ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
> if (bp->hw_dma_cap & HW_DMA_CAP_64B)
> dmacfg |= GEM_BIT(ADDR64);
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net: macb: Clean 64b dma addresses if they are not detected
2018-09-25 6:32 [PATCH v2] net: macb: Clean 64b dma addresses if they are not detected Michal Simek
2018-09-25 7:00 ` Nicolas Ferre
@ 2018-09-25 17:37 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-09-25 17:37 UTC (permalink / raw)
To: michal.simek; +Cc: linux-kernel, monstr, edgar.iglesias, netdev, nicolas.ferre
From: Michal Simek <michal.simek@xilinx.com>
Date: Tue, 25 Sep 2018 08:32:50 +0200
> Clear ADDR64 dma bit in DMACFG register in case that HW_DMA_CAP_64B is
> not detected on 64bit system.
> The issue was observed when bootloader(u-boot) does not check macb
> feature at DCFG6 register (DAW64_OFFSET) and enabling 64bit dma support
> by default. Then macb driver is reading DMACFG register back and only
> adding 64bit dma configuration but not cleaning it out.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> Changes in v2:
> - Clean reg at the first place - Edgar
> - Update commit message
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-25 17:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-25 6:32 [PATCH v2] net: macb: Clean 64b dma addresses if they are not detected Michal Simek
2018-09-25 7:00 ` Nicolas Ferre
2018-09-25 17:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).