From: David Miller <davem@davemloft.net>
To: salil.mehta@huawei.com
Cc: yisen.zhuang@huawei.com, lipeng321@huawei.com,
mehta.salil@opnsrc.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
linyunsheng@huawei.com
Subject: Re: [PATCH net] net: hns: fix for unmapping problem when SMMU is on
Date: Tue, 25 Sep 2018 10:43:36 -0700 (PDT) [thread overview]
Message-ID: <20180925.104336.2276354373880447447.davem@davemloft.net> (raw)
In-Reply-To: <20180925092155.11024-1-salil.mehta@huawei.com>
From: Salil Mehta <salil.mehta@huawei.com>
Date: Tue, 25 Sep 2018 10:21:55 +0100
> From: Yunsheng Lin <linyunsheng@huawei.com>
>
> If SMMU is on, there is more likely that skb_shinfo(skb)->frags[i]
> can not send by a single BD. when this happen, the
> hns_nic_net_xmit_hw function map the whole data in a frags using
> skb_frag_dma_map, but unmap each BD' data individually when tx is
> done, which causes problem when SMMU is on.
>
> This patch fixes this problem by ummapping the whole data in a
> frags when tx is done.
>
> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
> Signed-off-by: Peng Li <lipeng321@huawei.com>
> Reviewed-by: Yisen Zhuang <yisen.zhuang@huawei.com>
> Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Applied, thank you.
prev parent reply other threads:[~2018-09-25 17:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 9:21 [PATCH net] net: hns: fix for unmapping problem when SMMU is on Salil Mehta
2018-09-25 17:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925.104336.2276354373880447447.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=linyunsheng@huawei.com \
--cc=lipeng321@huawei.com \
--cc=mehta.salil@opnsrc.net \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).