From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [PATCH v2 net-next 0/9] bnxt_en: devlink param updates
Date: Tue, 25 Sep 2018 07:06:34 -0700
Message-ID: <20180925070634.05d05e83@cakuba.netronome.com>
References: <1537766181-18994-1-git-send-email-vasundhara-v.volam@broadcom.com>
        <20180924093908.157f3ea2@cakuba.netronome.com>
        <CAACQVJoR1LKyZmeNbRmjOL6w5iKfE2cnshRTs92r1zCXjiS_pg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>,
        "michael.chan@broadcom.com" <michael.chan@broadcom.com>,
        Netdev <netdev@vger.kernel.org>
To: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-qt1-f180.google.com ([209.85.160.180]:35161 "EHLO
        mail-qt1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729115AbeIYUOT (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 25 Sep 2018 16:14:19 -0400
Received: by mail-qt1-f180.google.com with SMTP id z14-v6so8443391qtn.2
        for <netdev@vger.kernel.org>; Tue, 25 Sep 2018 07:06:38 -0700 (PDT)
In-Reply-To: <CAACQVJoR1LKyZmeNbRmjOL6w5iKfE2cnshRTs92r1zCXjiS_pg@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, 25 Sep 2018 09:44:41 +0530, Vasundhara Volam wrote:
> On Mon, Sep 24, 2018 at 10:11 PM Jakub Kicinski
> <jakub.kicinski@netronome.com> wrote:
> >
> > On Mon, 24 Sep 2018 10:46:12 +0530, Vasundhara Volam wrote:  
> > > This patchset adds support for 3 generic and 1 driver-specific devlink
> > > parameters. Add documentation for these configuration parameters.
> > >
> > > Also, this patchset adds support to return proper error code if
> > > HWRM_NVM_GET/SET_VARIABLE commands return error code
> > > HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED.
> > >
> > > v1->v2:
> > > -Remove hw_tc_offload parameter.
> > > -Update all patches with Cc of MAINTAINERS.
> > > -Add more description in commit message for device specific parameter.
> > > -Add a new Documentation/networking/devlink-params.txt with some
> > > generic devlink parameters information.
> > > -Add a new Documentation/networking/devlink-params-bnxt_en.txt with devlink
> > > parameters information that are supported by bnxt_en driver.
> > >
> > > Vasundhara Volam (9):
> > >   devlink: Add generic parameter ignore_ari
> > >   devlink: Add generic parameter msix_vec_per_pf_max
> > >   devlink: Add generic parameter msix_vec_per_pf_min  
> >
> > Nobody agreed with me that we need structure the PCIe bits better so
> > I'll let go...
> >  
> > >   bnxt_en: Use ignore_ari devlink parameter
> > >   bnxt_en: return proper error when FW returns
> > >     HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED
> > >   bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink
> > >     params.
> > >   bnxt_en: Add a driver specific gre_ver_check devlink parameter.  
> >
> > This looks like configuring forwarding rules with devlink, but again,  
> Do you think, this parameter should be made generic?

By no means.

> > I won't object if I'm the only one who finds this inappropriate.
> >
> > You should CC people who gave you feedback on the previous version.  
> Sorry, I will add in the next version of the patchset. Thanks.
> >  
> > >   devlink: Add Documentation/networking/devlink-params.txt
> > >   devlink: Add Documentation/networking/devlink-params-bnxt.txt