From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [PATCH 3/5] ixgbe: add AF_XDP zero-copy Rx support
Date: Tue, 25 Sep 2018 07:57:14 -0700
Message-ID: <20180925075714.75db73ac@cakuba.netronome.com>
References: <20180924163557.1187-1-bjorn.topel@gmail.com>
        <20180924163557.1187-4-bjorn.topel@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org,
        =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn.topel@intel.com>,
        magnus.karlsson@intel.com, magnus.karlsson@gmail.com,
        ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org,
        brouer@redhat.com, u9012063@gmail.com, tuc@vmware.com
To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn.topel@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-qt1-f193.google.com ([209.85.160.193]:46383 "EHLO
        mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729805AbeIYVFM (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 25 Sep 2018 17:05:12 -0400
Received: by mail-qt1-f193.google.com with SMTP id h22-v6so5689077qtr.13
        for <netdev@vger.kernel.org>; Tue, 25 Sep 2018 07:57:19 -0700 (PDT)
In-Reply-To: <20180924163557.1187-4-bjorn.topel@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, 24 Sep 2018 18:35:55 +0200, Bj=C3=B6rn T=C3=B6pel wrote:
> +	if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED)
> +		return -EINVAL;
> +
> +	if (adapter->flags & IXGBE_FLAG_DCB_ENABLED)
> +		return -EINVAL;

Hm, should you add UMEM checks to all the places these may get
enabled?  Like fabf1bce103a ("ixgbe: Prevent unsupported configurations
with XDP") did?