netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Mariusz Stachura <mariusz.stachura@intel.com>,
	netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
	jogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 01/10] i40e: Fix VF's link state notification
Date: Tue, 25 Sep 2018 13:19:55 -0700	[thread overview]
Message-ID: <20180925202004.27726-2-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20180925202004.27726-1-jeffrey.t.kirsher@intel.com>

From: Mariusz Stachura <mariusz.stachura@intel.com>

This resolves an issue where the VF link state was not being updated
when the PF is down or up, and the VF link state would always show
that it is running.

Signed-off-by: Mariusz Stachura <mariusz.stachura@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index c7d2c9010fdf..fff53470e182 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -8509,14 +8509,9 @@ static void i40e_link_event(struct i40e_pf *pf)
 	i40e_status status;
 	bool new_link, old_link;
 
-	/* save off old link status information */
-	pf->hw.phy.link_info_old = pf->hw.phy.link_info;
-
 	/* set this to force the get_link_status call to refresh state */
 	pf->hw.phy.get_link_info = true;
-
 	old_link = (pf->hw.phy.link_info_old.link_info & I40E_AQ_LINK_UP);
-
 	status = i40e_get_link_status(&pf->hw, &new_link);
 
 	/* On success, disable temp link polling */
-- 
2.17.1

  reply	other threads:[~2018-09-26  2:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-25 20:19 [net-next 00/10][pull request] 40GbE Intel Wired LAN Driver Updates 2018-09-25 Jeff Kirsher
2018-09-25 20:19 ` Jeff Kirsher [this message]
2018-09-25 20:19 ` [net-next 02/10] i40e: Unset promiscuous settings on VF reset Jeff Kirsher
2018-09-25 20:19 ` [net-next 03/10] i40e: use declared variables for pf and hw Jeff Kirsher
2018-09-25 20:19 ` [net-next 04/10] i40e: add a helper function to validate a VF based on the vf id Jeff Kirsher
2018-09-25 20:19 ` [net-next 05/10] i40e: fix double 'NIC Link is Down' messages Jeff Kirsher
2018-09-25 20:20 ` [net-next 06/10] i40e: Remove unused msglen parameter from virtchnl functions Jeff Kirsher
2018-09-25 20:20 ` [net-next 07/10] i40e: clean zero-copy XDP Tx ring on shutdown/reset Jeff Kirsher
2018-09-25 20:20 ` [net-next 08/10] net: xsk: add a simple buffer reuse queue Jeff Kirsher
2018-09-25 20:20 ` [net-next 09/10] i40e: clean zero-copy XDP Rx ring on shutdown/reset Jeff Kirsher
2018-09-25 20:20 ` [net-next 10/10] i40e: disallow changing the number of descriptors when AF_XDP is on Jeff Kirsher
2018-09-26  3:25 ` [net-next 00/10][pull request] 40GbE Intel Wired LAN Driver Updates 2018-09-25 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180925202004.27726-2-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=jogreene@redhat.com \
    --cc=mariusz.stachura@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).