From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Sergey Nemov <sergey.nemov@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 05/10] i40e: fix double 'NIC Link is Down' messages
Date: Tue, 25 Sep 2018 13:19:59 -0700 [thread overview]
Message-ID: <20180925202004.27726-6-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20180925202004.27726-1-jeffrey.t.kirsher@intel.com>
From: Sergey Nemov <sergey.nemov@intel.com>
When isup is false meaning that interface is going to shut down
set new speed to 0 to avoid double 'NIC Link is Down' messages.
Signed-off-by: Sergey Nemov <sergey.nemov@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 102219cea67f..330bafe6a689 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -6431,7 +6431,10 @@ void i40e_print_link_message(struct i40e_vsi *vsi, bool isup)
char *req_fec = "";
char *an = "";
- new_speed = pf->hw.phy.link_info.link_speed;
+ if (isup)
+ new_speed = pf->hw.phy.link_info.link_speed;
+ else
+ new_speed = I40E_LINK_SPEED_UNKNOWN;
if ((vsi->current_isup == isup) && (vsi->current_speed == new_speed))
return;
--
2.17.1
next prev parent reply other threads:[~2018-09-26 2:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 20:19 [net-next 00/10][pull request] 40GbE Intel Wired LAN Driver Updates 2018-09-25 Jeff Kirsher
2018-09-25 20:19 ` [net-next 01/10] i40e: Fix VF's link state notification Jeff Kirsher
2018-09-25 20:19 ` [net-next 02/10] i40e: Unset promiscuous settings on VF reset Jeff Kirsher
2018-09-25 20:19 ` [net-next 03/10] i40e: use declared variables for pf and hw Jeff Kirsher
2018-09-25 20:19 ` [net-next 04/10] i40e: add a helper function to validate a VF based on the vf id Jeff Kirsher
2018-09-25 20:19 ` Jeff Kirsher [this message]
2018-09-25 20:20 ` [net-next 06/10] i40e: Remove unused msglen parameter from virtchnl functions Jeff Kirsher
2018-09-25 20:20 ` [net-next 07/10] i40e: clean zero-copy XDP Tx ring on shutdown/reset Jeff Kirsher
2018-09-25 20:20 ` [net-next 08/10] net: xsk: add a simple buffer reuse queue Jeff Kirsher
2018-09-25 20:20 ` [net-next 09/10] i40e: clean zero-copy XDP Rx ring on shutdown/reset Jeff Kirsher
2018-09-25 20:20 ` [net-next 10/10] i40e: disallow changing the number of descriptors when AF_XDP is on Jeff Kirsher
2018-09-26 3:25 ` [net-next 00/10][pull request] 40GbE Intel Wired LAN Driver Updates 2018-09-25 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925202004.27726-6-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
--cc=sergey.nemov@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).