From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: netdev@vger.kernel.org, dsahern@gmail.com
Subject: Re: [PATCH v3 0/5] netlink: nested policy validation
Date: Wed, 26 Sep 2018 10:21:54 -0700 (PDT) [thread overview]
Message-ID: <20180926.102154.1962354339786539715.davem@davemloft.net> (raw)
In-Reply-To: <20180926091534.22876-1-johannes@sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Wed, 26 Sep 2018 11:15:29 +0200
> This adds nested policy validation, which lets you specify the
> nested attribute type, e.g. NLA_NESTED with sub-policy, or the
> new NLA_NESTED_ARRAY with sub-sub-policy.
>
>
> Changes in v2:
> * move setting the bad attr pointer/message into validate_nla()
> * remove the recursion patch since that's no longer needed
> * simply skip the generic bad attr pointer/message setting in
> case of nested nla_validate() failing since that could fail
> only due to validate_nla() failing inside, which already sets
> the extack information
>
> Changes in v3:
> * fix NLA_REJECT to have an error message if none is in policy
Looks great Johannes, series applied.
Thanks!
next prev parent reply other threads:[~2018-09-26 23:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 9:15 [PATCH v3 0/5] netlink: nested policy validation Johannes Berg
2018-09-26 9:15 ` [PATCH v3 1/5] netlink: remove NLA_NESTED_COMPAT Johannes Berg
2018-09-26 9:15 ` [PATCH v3 2/5] netlink: make validation_data const Johannes Berg
2018-09-26 9:15 ` [PATCH v3 3/5] netlink: move extack setting into validate_nla() Johannes Berg
2018-09-26 9:15 ` [PATCH v3 4/5] netlink: allow NLA_NESTED to specify nested policy to validate Johannes Berg
2018-09-26 9:15 ` [PATCH v3 5/5] netlink: add nested array policy validation Johannes Berg
2018-09-26 17:21 ` David Miller [this message]
2018-09-27 8:22 ` [PATCH v3 0/5] netlink: nested " Johannes Berg
2018-09-28 17:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926.102154.1962354339786539715.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).