From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v3 0/5] netlink: nested policy validation Date: Wed, 26 Sep 2018 10:21:54 -0700 (PDT) Message-ID: <20180926.102154.1962354339786539715.davem@davemloft.net> References: <20180926091534.22876-1-johannes@sipsolutions.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, dsahern@gmail.com To: johannes@sipsolutions.net Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:57454 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726023AbeIZXfw (ORCPT ); Wed, 26 Sep 2018 19:35:52 -0400 In-Reply-To: <20180926091534.22876-1-johannes@sipsolutions.net> Sender: netdev-owner@vger.kernel.org List-ID: From: Johannes Berg Date: Wed, 26 Sep 2018 11:15:29 +0200 > This adds nested policy validation, which lets you specify the > nested attribute type, e.g. NLA_NESTED with sub-policy, or the > new NLA_NESTED_ARRAY with sub-sub-policy. > > > Changes in v2: > * move setting the bad attr pointer/message into validate_nla() > * remove the recursion patch since that's no longer needed > * simply skip the generic bad attr pointer/message setting in > case of nested nla_validate() failing since that could fail > only due to validate_nla() failing inside, which already sets > the extack information > > Changes in v3: > * fix NLA_REJECT to have an error message if none is in policy Looks great Johannes, series applied. Thanks!