* [PATCH net-next] net: aquantia: Make function aq_fw1x_set_power() static
@ 2018-09-26 12:20 Wei Yongjun
2018-09-26 17:32 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2018-09-26 12:20 UTC (permalink / raw)
To: Igor Russkikh, Nikita Danilov, Yana Esina, Andrew Lunn
Cc: Wei Yongjun, netdev, kernel-janitors
Fixes the following sparse warning:
drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c:873:5: warning:
symbol 'aq_fw1x_set_power' was not declared. Should it be static?
Fixes: a0da96c08cfa ("net: aquantia: implement WOL support")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c
index 0dd59b09..7def1cb 100644
--- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c
+++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c
@@ -870,8 +870,8 @@ static int aq_fw1x_set_wol(struct aq_hw_s *self, bool wol_enabled, u8 *mac)
return err;
}
-int aq_fw1x_set_power(struct aq_hw_s *self, unsigned int power_state,
- u8 *mac)
+static int aq_fw1x_set_power(struct aq_hw_s *self, unsigned int power_state,
+ u8 *mac)
{
struct hw_atl_utils_fw_rpc *prpc = NULL;
unsigned int rpc_size = 0U;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: aquantia: Make function aq_fw1x_set_power() static
2018-09-26 12:20 [PATCH net-next] net: aquantia: Make function aq_fw1x_set_power() static Wei Yongjun
@ 2018-09-26 17:32 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-09-26 17:32 UTC (permalink / raw)
To: weiyongjun1
Cc: igor.russkikh, nikita.danilov, yana.esina, andrew, netdev,
kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Wed, 26 Sep 2018 12:20:00 +0000
> Fixes the following sparse warning:
>
> drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c:873:5: warning:
> symbol 'aq_fw1x_set_power' was not declared. Should it be static?
>
> Fixes: a0da96c08cfa ("net: aquantia: implement WOL support")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-26 23:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-26 12:20 [PATCH net-next] net: aquantia: Make function aq_fw1x_set_power() static Wei Yongjun
2018-09-26 17:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).