From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: madalin.bucur@nxp.com, andrew@lunn.ch, f.fainelli@gmail.com,
yangbo.lu@nxp.com, mail@jakemoroni.com, gustavo@embeddedor.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: ethernet: dpaa: remove unused variables
Date: Wed, 26 Sep 2018 10:35:06 -0700 (PDT) [thread overview]
Message-ID: <20180926.103506.950692305206471144.davem@davemloft.net> (raw)
In-Reply-To: <20180926131225.2661703-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 26 Sep 2018 15:12:13 +0200
> The patch that removed the only users of the oldadv/newadv variables
> accidentally left the now-unused declarations behind:
>
> drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c: In function 'dpaa_set_pauseparam':
> drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c:185:14: error: unused variable 'oldadv' [-Werror=unused-variable]
> drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c:185:6: error: unused variable 'newadv' [-Werror=unused-variable]
>
> Fixes: 70814e819c11 ("net: ethernet: Add helper for set_pauseparam for Asym Pause")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
prev parent reply other threads:[~2018-09-26 17:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 13:12 [PATCH net-next] net: ethernet: dpaa: remove unused variables Arnd Bergmann
2018-09-26 17:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926.103506.950692305206471144.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=f.fainelli@gmail.com \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=mail@jakemoroni.com \
--cc=netdev@vger.kernel.org \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox