From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] phy: mscc: fix printf format Date: Wed, 26 Sep 2018 10:37:12 -0700 (PDT) Message-ID: <20180926.103712.516726977452765505.davem@davemloft.net> References: <20180926132021.2933754-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: andrew@lunn.ch, f.fainelli@gmail.com, quentin.schulz@bootlin.com, alexandre.belloni@bootlin.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: arnd@arndb.de Return-path: In-Reply-To: <20180926132021.2933754-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Arnd Bergmann Date: Wed, 26 Sep 2018 15:20:11 +0200 > gcc points out that the length of the temporary buffer may not be sufficient for > large numbers of leds: > > drivers/net/phy/mscc.c: In function 'vsc85xx_probe': > drivers/net/phy/mscc.c:460:45: error: '-mode' directive writing 5 bytes into a region of size between 0 and 9 [-Werror=format-overflow=] > ret = sprintf(led_dt_prop, "vsc8531,led-%d-mode", i); > ^~~~~ > drivers/net/phy/mscc.c:460:9: note: 'sprintf' output between 19 and 28 bytes into a destination of size 22 > ret = sprintf(led_dt_prop, "vsc8531,led-%d-mode", i); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > While we can make a reasonable assumption that the number of LEDs is small, > the cost of making the buffer a little bigger is insignificant as well. > > Fixes: 11bfdabb7ff5 ("net: phy: mscc: factorize code for LEDs mode") > Signed-off-by: Arnd Bergmann Applied.