From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2] qed: Avoid implicit enum conversion in qed_roce_mode_to_flavor Date: Wed, 26 Sep 2018 20:19:40 -0700 (PDT) Message-ID: <20180926.201940.800778593716150299.davem@davemloft.net> References: <20180924213120.18979-1-natechancellor@gmail.com> <20180924213452.19334-1-natechancellor@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Ariel.Elior@cavium.com, everest-linux-l2@cavium.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: natechancellor@gmail.com Return-path: In-Reply-To: <20180924213452.19334-1-natechancellor@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Nathan Chancellor Date: Mon, 24 Sep 2018 14:34:53 -0700 > Clang warns when one enumerated type is implicitly converted to another. > > drivers/net/ethernet/qlogic/qed/qed_roce.c:153:12: warning: implicit > conversion from enumeration type 'enum roce_mode' to different > enumeration type 'enum roce_flavor' [-Wenum-conversion] > flavor = ROCE_V2_IPV6; > ~ ^~~~~~~~~~~~ > drivers/net/ethernet/qlogic/qed/qed_roce.c:156:12: warning: implicit > conversion from enumeration type 'enum roce_mode' to different > enumeration type 'enum roce_flavor' [-Wenum-conversion] > flavor = MAX_ROCE_MODE; > ~ ^~~~~~~~~~~~~ > 2 warnings generated. > > Use the appropriate values from the expected type, roce_flavor: > > ROCE_V2_IPV6 = RROCE_IPV6 = 2 > MAX_ROCE_MODE = MAX_ROCE_FLAVOR = 3 > > While we're add it, ditch the local variable flavor, we can just return > the value directly from the switch statement. > > Link: https://github.com/ClangBuiltLinux/linux/issues/125 > Signed-off-by: Nathan Chancellor > --- > > v1 -> v2: > > * s/if statement/switch statement/ in commit message Applied.