From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] net: phy: improve handling delayed work Date: Wed, 26 Sep 2018 20:20:04 -0700 (PDT) Message-ID: <20180926.202004.950719927882457576.davem@davemloft.net> References: <002b6ead-9d72-0995-4ac7-369a4422b026@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: f.fainelli@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org To: hkallweit1@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:37630 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726469AbeI0JgI (ORCPT ); Thu, 27 Sep 2018 05:36:08 -0400 In-Reply-To: <002b6ead-9d72-0995-4ac7-369a4422b026@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Heiner Kallweit Date: Mon, 24 Sep 2018 23:36:50 +0200 > diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c > index a1f8e4816..40a7dc101 100644 > --- a/drivers/net/phy/phy.c > +++ b/drivers/net/phy/phy.c ... > @@ -635,6 +635,13 @@ int phy_speed_up(struct phy_device *phydev) > } > EXPORT_SYMBOL_GPL(phy_speed_up); > > +static inline void phy_queue_state_machine(struct phy_device *phydev, > + unsigned int secs) > +{ Please do not use the inline keyword in foo.c files, let the compiler decide.