From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] qed: Avoid implicit enum conversion in qed_iwarp_parse_rx_pkt Date: Wed, 26 Sep 2018 20:24:45 -0700 (PDT) Message-ID: <20180926.202445.374568259168708755.davem@davemloft.net> References: <20180924214212.22522-1-natechancellor@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Ariel.Elior@cavium.com, everest-linux-l2@cavium.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: natechancellor@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:37690 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726539AbeI0Jku (ORCPT ); Thu, 27 Sep 2018 05:40:50 -0400 In-Reply-To: <20180924214212.22522-1-natechancellor@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Nathan Chancellor Date: Mon, 24 Sep 2018 14:42:12 -0700 > Clang warns when one enumerated type is implicitly converted to another. > > drivers/net/ethernet/qlogic/qed/qed_iwarp.c:1713:25: warning: implicit > conversion from enumeration type 'enum tcp_ip_version' to different > enumeration type 'enum qed_tcp_ip_version' [-Wenum-conversion] > cm_info->ip_version = TCP_IPV4; > ~ ^~~~~~~~ > drivers/net/ethernet/qlogic/qed/qed_iwarp.c:1733:25: warning: implicit > conversion from enumeration type 'enum tcp_ip_version' to different > enumeration type 'enum qed_tcp_ip_version' [-Wenum-conversion] > cm_info->ip_version = TCP_IPV6; > ~ ^~~~~~~~ > 2 warnings generated. > > Use the appropriate values from the expected type, qed_tcp_ip_version: > > TCP_IPV4 = QED_TCP_IPV4 = 0 > TCP_IPV6 = QED_TCP_IPV6 = 1 > > Link: https://github.com/ClangBuiltLinux/linux/issues/125 > Signed-off-by: Nathan Chancellor Applied.