From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] qed: Avoid constant logical operation warning in qed_vf_pf_acquire Date: Wed, 26 Sep 2018 20:24:50 -0700 (PDT) Message-ID: <20180926.202450.236688165629228809.davem@davemloft.net> References: <20180924221703.26454-1-natechancellor@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Ariel.Elior@cavium.com, everest-linux-l2@cavium.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: natechancellor@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:37696 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726539AbeI0Jkz (ORCPT ); Thu, 27 Sep 2018 05:40:55 -0400 In-Reply-To: <20180924221703.26454-1-natechancellor@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Nathan Chancellor Date: Mon, 24 Sep 2018 15:17:03 -0700 > Clang warns when a constant is used in a boolean context as it thinks a > bitwise operation may have been intended. > > drivers/net/ethernet/qlogic/qed/qed_vf.c:415:27: warning: use of logical > '&&' with constant operand [-Wconstant-logical-operand] > if (!p_iov->b_pre_fp_hsi && > ^ > drivers/net/ethernet/qlogic/qed/qed_vf.c:415:27: note: use '&' for a > bitwise operation > if (!p_iov->b_pre_fp_hsi && > ^~ > & > drivers/net/ethernet/qlogic/qed/qed_vf.c:415:27: note: remove constant > to silence this warning > if (!p_iov->b_pre_fp_hsi && > ~^~ > 1 warning generated. > > This has been here since commit 1fe614d10f45 ("qed: Relax VF firmware > requirements") and I am not entirely sure why since 0 isn't a special > case. Just remove the statement causing Clang to warn since it isn't > required. > > Link: https://github.com/ClangBuiltLinux/linux/issues/126 > Signed-off-by: Nathan Chancellor Applied.