From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guillaume Nault Subject: Re: [PATCH net-next] l2tp: fix return type of ndo_start_xmit function Date: Wed, 26 Sep 2018 13:43:30 +0200 Message-ID: <20180926114330.GA1487@alphalink.fr> References: <20180926103839.28584-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, arnd@arndb.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: YueHaibing Return-path: Content-Disposition: inline In-Reply-To: <20180926103839.28584-1-yuehaibing@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, Sep 26, 2018 at 06:38:39PM +0800, YueHaibing wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, so make sure the implementation in > this driver has returns 'netdev_tx_t' value, and change the function > return type to netdev_tx_t. > > Found by coccinelle. > > Signed-off-by: YueHaibing > --- > net/l2tp/l2tp_eth.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/l2tp/l2tp_eth.c b/net/l2tp/l2tp_eth.c > index 8aadc4f..4173cb1 100644 > --- a/net/l2tp/l2tp_eth.c > +++ b/net/l2tp/l2tp_eth.c > @@ -77,7 +77,8 @@ static void l2tp_eth_dev_uninit(struct net_device *dev) > */ > } > > -static int l2tp_eth_dev_xmit(struct sk_buff *skb, struct net_device *dev) > +static netdev_tx_t > +l2tp_eth_dev_xmit(struct sk_buff *skb, struct net_device *dev) Return type and function name are generally kept on the same line: +static netdev_tx_t l2tp_eth_dev_xmit(struct sk_buff *skb, + struct net_device *dev) Anyway, Acked-by: Guillaume Nault