From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ido Schimmel <idosch@idosch.org>
Subject: Re: [PATCH net-next 9/9] net: bridge: pack net_bridge better
Date: Wed, 26 Sep 2018 16:30:14 +0300
Message-ID: <20180926133014.GA31563@splinter>
References: <20180926121802.27851-1-nikolay@cumulusnetworks.com>
 <20180926121802.27851-10-nikolay@cumulusnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
        davem@davemloft.net, stephen@networkplumber.org,
        bridge@lists.linux-foundation.org
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:38065 "EHLO
        out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1726602AbeIZTnR (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 26 Sep 2018 15:43:17 -0400
Content-Disposition: inline
In-Reply-To: <20180926121802.27851-10-nikolay@cumulusnetworks.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Sep 26, 2018 at 03:18:02PM +0300, Nikolay Aleksandrov wrote:
> Further reduce the size of net_bridge with 8 bytes and reduce the number of
> holes in it:
>  Before: holes: 5, sum holes: 15
>  After: holes: 2, sum holes: 3
> 
> Also as a bonus we get offload_fwd_mark in the first cache line and remove
> the need to pull the last cache line of net_bridge just for that member in
> fast path (should_deliver -> nbp_switchdev_allowed_egress).

But nbp_switchdev_allowed_egress() compares with 'offload_fwd_mark' from
'net_bridge_port', not 'net_bridge'...