From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Andrey Ignatov <rdna@fb.com>
Cc: <netdev@vger.kernel.org>, <ast@kernel.org>,
<daniel@iogearbox.net>, <kernel-team@fb.com>
Subject: Re: [PATCH bpf-next 0/5] Introduce libbpf_attach_type_by_name
Date: Wed, 26 Sep 2018 16:20:07 -0700 [thread overview]
Message-ID: <20180926162007.37a4b873@cakuba.netronome.com> (raw)
In-Reply-To: <cover.1538000102.git.rdna@fb.com>
On Wed, 26 Sep 2018 15:24:52 -0700, Andrey Ignatov wrote:
> This patch set introduces libbpf_attach_type_by_name function in libbpf to
> identify attach type by section name.
>
> This is useful to avoid writing same logic over and over again in user
> space applications that leverage libbpf.
>
> Patch 1 has more details on the new function and problem being solved.
> Patches 2 and 3 add support for new section names.
> Patch 4 uses new function in a selftest.
> Patch 5 adds selftest for libbpf_{prog,attach}_type_by_name.
>
> As a side note there are a lot of inconsistencies now between names used by
> libbpf and bpftool (e.g. cgroup/skb vs cgroup_skb, cgroup_device and device
> vs cgroup/dev, sockops vs sock_ops, etc). This patch set does not address
> it but it tries not to make it harder to address it in the future.
I was wondering a few times whether I should point it out to people
during review, but thought it would be nit picking. Maybe we should be
more strict.
Your series LGTM!
next prev parent reply other threads:[~2018-09-27 5:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 22:24 [PATCH bpf-next 0/5] Introduce libbpf_attach_type_by_name Andrey Ignatov
2018-09-26 22:24 ` [PATCH bpf-next 1/5] libbpf: " Andrey Ignatov
2018-09-26 22:24 ` [PATCH bpf-next 2/5] libbpf: Support cgroup_skb/{e,in}gress section names Andrey Ignatov
2018-09-26 22:24 ` [PATCH bpf-next 3/5] libbpf: Support sk_skb/stream_{parser,verdict} " Andrey Ignatov
2018-09-26 22:24 ` [PATCH bpf-next 4/5] selftests/bpf: Use libbpf_attach_type_by_name in test_socket_cookie Andrey Ignatov
2018-09-26 22:24 ` [PATCH bpf-next 5/5] selftests/bpf: Test libbpf_{prog,attach}_type_by_name Andrey Ignatov
2018-09-26 23:20 ` Jakub Kicinski [this message]
2018-09-26 23:54 ` [PATCH bpf-next 0/5] Introduce libbpf_attach_type_by_name Andrey Ignatov
2018-09-27 2:06 ` Jakub Kicinski
2018-09-27 19:21 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926162007.37a4b873@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=rdna@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).