From: Dominique Martinet <asmadeus@codewreck.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Eric Van Hensbergen <ericvh@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
Latchesar Ionkov <lucho@ionkov.net>,
"David S. Miller" <davem@davemloft.net>,
v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] 9p: potential NULL dereference
Date: Wed, 26 Sep 2018 23:07:26 +0200 [thread overview]
Message-ID: <20180926210726.GA29761@nautica> (raw)
In-Reply-To: <20180926103934.GA14535@mwanda>
Dan Carpenter wrote on Wed, Sep 26, 2018:
> p9_tag_alloc() is supposed to return error pointers, but we accidentally
> return a NULL here. It would cause a NULL dereference in the caller.
>
> Fixes: 996d5b4db4b1 ("9p: Use a slab for allocating requests")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Good catch, the culprit commit is only in -next so just adding this to
the queue right away.
Thanks!
--
Dominique
prev parent reply other threads:[~2018-09-27 3:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 10:39 [PATCH] 9p: potential NULL dereference Dan Carpenter
2018-09-26 21:07 ` Dominique Martinet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926210726.GA29761@nautica \
--to=asmadeus@codewreck.org \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=ericvh@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).