From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: re iproute2 - don't return error on success fix
Date: Thu, 27 Sep 2018 13:39:26 +0100
Message-ID: <20180927133926.206e7bda@shemminger-XPS-13-9360>
References: <CAJ3xEMiasPrGAQkY=uVxCaFG_An1cm+emJCc6jr76=xuLcQ=0Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: David Ahern <dsahern@gmail.com>,
        Linux Netdev List <netdev@vger.kernel.org>,
        Roi Dayan <roid@mellanox.com>
To: Or Gerlitz <gerlitz.or@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-ed1-f44.google.com ([209.85.208.44]:35601 "EHLO
        mail-ed1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727108AbeI0S5i (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 27 Sep 2018 14:57:38 -0400
Received: by mail-ed1-f44.google.com with SMTP id y21-v6so4912553edr.2
        for <netdev@vger.kernel.org>; Thu, 27 Sep 2018 05:39:32 -0700 (PDT)
In-Reply-To: <CAJ3xEMiasPrGAQkY=uVxCaFG_An1cm+emJCc6jr76=xuLcQ=0Q@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, 27 Sep 2018 15:22:41 +0300
Or Gerlitz <gerlitz.or@gmail.com> wrote:

> Something is still broken also after commit b45e300 "libnetlink: don't
> return error on success" - when error is returned, the error code is
> success..
> 
> $ tc filter add dev enp33s0f0 protocol ip parent ffff: flower skip_sw
> ip_flags nofirstfrag action drop && echo "success" || echo "failed"
> 
Yes this looks broken. Let me check.