From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] net: dsa: b53: Fix build with B53_SRAB enabled and B53_SERDES=m Date: Fri, 28 Sep 2018 10:35:51 -0700 (PDT) Message-ID: <20180928.103551.1326259433509149179.davem@davemloft.net> References: <20180927100244.692546-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: arnd@arndb.de, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: f.fainelli@gmail.com Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Florian Fainelli Date: Thu, 27 Sep 2018 12:07:01 -0700 > On 09/27/2018 03:02 AM, Arnd Bergmann wrote: >> When B53_SERDES is a loadable module, a built-in srab driver still >> cannot reach it, so the previous fix is incomplete: >> >> b53_srab.c:(.text+0x3f4): undefined reference to `b53_serdes_init' >> drivers/net/dsa/b53/b53_srab.o:(.rodata+0xe64): undefined reference to `b53_serdes_link_state' >> drivers/net/dsa/b53/b53_srab.o:(.rodata+0xe74): undefined reference to `b53_serdes_link_set' >> drivers/net/dsa/b53/b53_srab.o:(.rodata+0xe88): undefined reference to `b53_serdes_an_restart' >> drivers/net/dsa/b53/b53_srab.o:(.rodata+0xea0): undefined reference to `b53_serdes_phylink_validate' >> drivers/net/dsa/b53/b53_srab.o:(.rodata+0xea4): undefined reference to `b53_serdes_config' >> >> Add a Kconfig dependency that forces srab to also be a module >> in this case, but allow it to be built-in when serdes is >> disabled or built-in. >> >> Fixes: 7a8c7f5c30f9 ("net: dsa: b53: Fix build with B53_SRAB enabled and not B53_SERDES") >> Signed-off-by: Arnd Bergmann > > Acked-by: Florian Fainelli Applied, thanks Arnd.