From: David Miller <davem@davemloft.net>
To: sudarsana.kalluru@cavium.com
Cc: netdev@vger.kernel.org, Michal.Kalderon@cavium.com
Subject: Re: [PATCH net 1/1] qed: Fix shmem structure inconsistency between driver and the mfw.
Date: Fri, 28 Sep 2018 10:40:39 -0700 (PDT) [thread overview]
Message-ID: <20180928.104039.181198681434515123.davem@davemloft.net> (raw)
In-Reply-To: <20180927111210.14203-1-sudarsana.kalluru@cavium.com>
From: Sudarsana Reddy Kalluru <sudarsana.kalluru@cavium.com>
Date: Thu, 27 Sep 2018 04:12:10 -0700
> The structure shared between driver and the management FW (mfw) differ in
> sizes. This would lead to issues when driver try to access the structure
> members which are not-aligned with the mfw copy e.g., data_ptr usage in the
> case of mfw_tlv request.
> Align the driver structure with mfw copy, add reserved field(s) to driver
> structure for the members not used by the driver.
>
> Fixes: dd006921d ("qed: Add MFW interfaces for TLV request support.)
> Signed-off-by: Sudarsana Reddy Kalluru <Sudarsana.Kalluru@cavium.com>
> Signed-off-by: Michal Kalderon <Michal.Kalderon@cavium.com>
Applied and queued up for -stable.
In the future please use 12 digits of SHA1_ID for Fixes tags. I fixed
it up for you this time.
Thanks.
prev parent reply other threads:[~2018-09-29 0:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 11:12 [PATCH net 1/1] qed: Fix shmem structure inconsistency between driver and the mfw Sudarsana Reddy Kalluru
2018-09-28 17:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180928.104039.181198681434515123.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Michal.Kalderon@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=sudarsana.kalluru@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).