From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net 1/1] qed: Fix shmem structure inconsistency between driver and the mfw. Date: Fri, 28 Sep 2018 10:40:39 -0700 (PDT) Message-ID: <20180928.104039.181198681434515123.davem@davemloft.net> References: <20180927111210.14203-1-sudarsana.kalluru@cavium.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Michal.Kalderon@cavium.com To: sudarsana.kalluru@cavium.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:39112 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726100AbeI2AFa (ORCPT ); Fri, 28 Sep 2018 20:05:30 -0400 In-Reply-To: <20180927111210.14203-1-sudarsana.kalluru@cavium.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Sudarsana Reddy Kalluru Date: Thu, 27 Sep 2018 04:12:10 -0700 > The structure shared between driver and the management FW (mfw) differ in > sizes. This would lead to issues when driver try to access the structure > members which are not-aligned with the mfw copy e.g., data_ptr usage in the > case of mfw_tlv request. > Align the driver structure with mfw copy, add reserved field(s) to driver > structure for the members not used by the driver. > > Fixes: dd006921d ("qed: Add MFW interfaces for TLV request support.) > Signed-off-by: Sudarsana Reddy Kalluru > Signed-off-by: Michal Kalderon Applied and queued up for -stable. In the future please use 12 digits of SHA1_ID for Fixes tags. I fixed it up for you this time. Thanks.